-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove wasabi, jalapeno, and the buildType flavor dimension #22651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
23efaac
62fc843
c3abc64
7fecd00
a63475c
c97d937
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,11 +54,11 @@ fladle { | |
| } | ||
|
|
||
| String appPathForVariant(String app) { | ||
| String path = "outputs/apk/${app}Vanilla/debug" | ||
| String path = "outputs/apk/${app}/debug" | ||
| return new File(layout.buildDirectory.dir(path).get().asFile, '*.apk').absolutePath | ||
| } | ||
| String testPathForVariant(String app) { | ||
| String path = "outputs/apk/androidTest/${app}Vanilla/debug" | ||
| String path = "outputs/apk/androidTest/${app}/debug" | ||
| return new File(layout.buildDirectory.dir(path).get().asFile, '*.apk').absolutePath | ||
| } | ||
|
|
||
|
|
@@ -195,7 +195,7 @@ android { | |
| targetCompatibility JvmTarget.fromTarget(libs.versions.java.get()).target | ||
| } | ||
|
|
||
| flavorDimensions = ['app', 'buildType'] | ||
| flavorDimensions = ['app'] | ||
|
|
||
|
|
||
| productFlavors { | ||
|
|
@@ -242,29 +242,6 @@ android { | |
| resourceConfigurations += ["in", "iw"] | ||
| } | ||
|
|
||
| // Used for release/beta testing builds. Usually shouldn't be build locally. | ||
| // AppName: WordPress/Jetpack | ||
| vanilla { | ||
| dimension "buildType" | ||
|
|
||
| buildConfigField "boolean", "ENABLE_DEBUG_SETTINGS", "false" | ||
| } | ||
|
|
||
| // Used for local development - preferred variant for developers. | ||
| // AppName: WordPress Beta/Jetpack Beta | ||
| wasabi { | ||
| isDefault true | ||
| applicationIdSuffix ".beta" | ||
| dimension "buildType" | ||
| } | ||
|
|
||
| // Used for CI builds on PRs (aka "Prototype Builds"). Can be used locally when a developer needs to install multiple versions of the app on the same device. | ||
| // AppName: WordPress Pre-Alpha/Jetpack Pre-Alpha | ||
| jalapeno { | ||
| applicationIdSuffix ".prealpha" | ||
| dimension "buildType" | ||
| } | ||
|
|
||
| // Also dynamically add additional `buildConfigFields` to our app flavors from any `wp.`/`jp.`-prefixed property in `secrets.properties` | ||
| addBuildConfigFieldsFromPrefixedProperties(wordpress, gradle.ext.secretProperties, ['wp']) | ||
| addBuildConfigFieldsFromPrefixedProperties(jetpack, gradle.ext.secretProperties, ['wp', 'jp']) // Inherit same properties used from WP first then overwrite with JP-specific ones | ||
|
|
@@ -276,9 +253,11 @@ android { | |
| // but we don't obfuscate the bytecode. | ||
| minifyEnabled true | ||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard.cfg' | ||
| buildConfigField "boolean", "ENABLE_DEBUG_SETTINGS", "false" | ||
| } | ||
|
|
||
| debug { | ||
| applicationIdSuffix ".prealpha" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ Any special reason why debug variant is adding
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good question @adalpari , and I'll try to answer for @jkmassel (if I might, and until he adds his answer)... 😊 🙏
As such, and having said that, I think Jeremy make the right call here, doing what he did. 💯 🤞
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This was the reasoning – I wanted to be able to continue to upload to Firebase for PR builds without needing to modify remote configuration. If we want to squash this down too I'm good with it, but maybe a subsequent PR? |
||
| minifyEnabled false | ||
| pseudoLocalesEnabled true | ||
| } | ||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.