Skip to content

Fix an issue with site icons cropped in share extensions#23950

Merged
kean merged 6 commits intochristmas-feature-branchfrom
fix/site-icon-cropped-share-extension
Jan 6, 2025
Merged

Fix an issue with site icons cropped in share extensions#23950
kean merged 6 commits intochristmas-feature-branchfrom
fix/site-icon-cropped-share-extension

Conversation

@kean
Copy link
Contributor

@kean kean commented Jan 6, 2025

Fixes #7028

Changes:

  • Move SiteIconView to WordPressUI
  • Update ShareModularViewController to use SiteIconView in site cells
  • Remove unused downloadBlavatar
Screenshot 2025-01-06 at 5 04 20 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.7 milestone Jan 6, 2025
@kean kean changed the base branch from trunk to christmas-feature-branch January 6, 2025 22:06
@kean kean merged commit 6e32673 into christmas-feature-branch Jan 6, 2025
1 check was pending
@kean kean deleted the fix/site-icon-cropped-share-extension branch January 6, 2025 22:09
@kean kean mentioned this pull request Jan 6, 2025
14 tasks
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23950-0862ef1
Version25.6
Bundle IDorg.wordpress.alpha
Commit0862ef1
App Center BuildWPiOS - One-Offs #11284
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23950-0862ef1
Version25.6
Bundle IDcom.jetpack.alpha
Commit0862ef1
App Center Buildjetpack-installable-builds #10320
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants