Skip to content

Conversation

@crazytonyli
Copy link
Contributor

Fixes #21856.

Requires wordpress-mobile/WordPressKit-iOS#832.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Mar 10, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean March 10, 2025 22:59
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 10, 2025

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24181-ff48310
Version25.8
Bundle IDorg.wordpress.alpha
Commitff48310
App Center BuildWPiOS - One-Offs #11621
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24181-ff48310
Version25.8
Bundle IDcom.jetpack.alpha
Commitff48310
App Center Buildjetpack-installable-builds #10652
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli crazytonyli requested a review from pmusolino March 11, 2025 07:48
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! The code looks good, but let's hold off a little bit while Gio is working on WordPressData to avoid creating merge conflicts for him.

@crazytonyli crazytonyli force-pushed the issue-21856-support-page-order branch from ff48310 to c160ab8 Compare April 14, 2025 09:17
@crazytonyli crazytonyli marked this pull request as ready for review April 14, 2025 09:20
@crazytonyli
Copy link
Contributor Author

A new Core Data model version was added in #24424. I figure it'd be okay to merge this PR since the diff is relatively small now.

@crazytonyli crazytonyli requested a review from kean April 14, 2025 09:21
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27306
VersionPR #24181
Bundle IDorg.wordpress.alpha
Commitc160ab8
Installation URL3s3hp1ak785d8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27306
VersionPR #24181
Bundle IDcom.jetpack.alpha
Commitc160ab8
Installation URL285lj5af75k70
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli added this pull request to the merge queue Apr 14, 2025
Merged via the queue into trunk with commit 878ac5f Apr 14, 2025
33 checks passed
@crazytonyli crazytonyli deleted the issue-21856-support-page-order branch April 14, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pages order doesn't match the web with custom ordering

5 participants