-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix #21856: Support the 'Order' setting in pages list #24181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24181-ff48310 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ff48310 | |
| App Center Build | WPiOS - One-Offs #11621 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24181-ff48310 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ff48310 | |
| App Center Build | jetpack-installable-builds #10652 |
kean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! The code looks good, but let's hold off a little bit while Gio is working on WordPressData to avoid creating merge conflicts for him.
ff48310 to
c160ab8
Compare
|
A new Core Data model version was added in #24424. I figure it'd be okay to merge this PR since the diff is relatively small now. |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27306 | |
| Version | PR #24181 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c160ab8 | |
| Installation URL | 3s3hp1ak785d8 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27306 | |
| Version | PR #24181 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c160ab8 | |
| Installation URL | 285lj5af75k70 |


Fixes #21856.
Requires wordpress-mobile/WordPressKit-iOS#832.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: