Skip to content

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Apr 4, 2025

Why?

Now that we've migrated to release-toolkit version 13.1, which includes wordpress-mobile/release-toolkit#638 that already handles inserting Buildkite-aware collapsible groups in CI logs for all repos, the custom logic that was added specifically in WPiOS Fastfile is no longer needed now that it's handled by the release-toolkit itself, and in fact keeping the existing logic in WPiOS' Fastfile duplicated the logs in CI

Testing

Look at the CI logs for this PR and confirm that the collapsible groups inserted in CI logs are no longer duplicated.

This is what it looked before, right after the project updated to release-toolkit version 13.1:

image

This is what it looks like now, without any duplication anymore:

image

Now that we've migrated to `release-toolkit` version `13.1`, which includes wordpress-mobile/release-toolkit#638 that already handles inserting Buildkite-aware collapsible groups in CI logs, the custom logic that was added in WPiOS Fastfile only is no longer needed, and in fact duplicated the logs in CI
@AliSoftware AliSoftware added the Tooling Build, Release, and Validation Tools label Apr 4, 2025
@AliSoftware AliSoftware self-assigned this Apr 4, 2025
@AliSoftware AliSoftware added this to the 26.0 milestone Apr 4, 2025
@AliSoftware AliSoftware requested review from a team and crazytonyli April 4, 2025 10:56
@AliSoftware AliSoftware enabled auto-merge April 4, 2025 10:58
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27121
VersionPR #24412
Bundle IDorg.wordpress.alpha
Commit43eb3f4
Installation URL7icvu2hsflum8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27121
VersionPR #24412
Bundle IDcom.jetpack.alpha
Commit43eb3f4
Installation URL0872d17asdfvg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@AliSoftware AliSoftware added this pull request to the merge queue Apr 6, 2025
Merged via the queue into trunk with commit 46452e5 Apr 6, 2025
33 checks passed
@AliSoftware AliSoftware deleted the tooling/remove-duplicate-ci-logs branch April 6, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants