-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add "Status" row to "Post Settings" #24939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 29471 | |
Version | PR #24939 | |
Bundle ID | com.jetpack.alpha | |
Commit | ba92c56 | |
Installation URL | 6ufhls30caf6o |
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 29471 | |
Version | PR #24939 | |
Bundle ID | org.wordpress.alpha | |
Commit | ba92c56 | |
Installation URL | 69n647aktqlq0 |
authorRow | ||
if !viewModel.isDraftOrPending || viewModel.context == .publishing { | ||
publishDateRow | ||
visibilityRow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visilbilityRow
is displayed at the top of the screen in the "Publishing" sheet (matches the web).
let settings = getSettingsToSave(for: self.settings) | ||
let coordinator = PostCoordinator.shared | ||
if coordinator.isSyncAllowed(for: post) { | ||
if coordinator.isSyncAllowed(for: post) && post.status == settings.status { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you try to change the status of a post, it will be performed as a synchronous operation (showing a spinner until succeeds).
|
Description
One of the defining characteristics of WordPress is the set of statuses for posts and how you can easily move a post from one state to another. This PR introduces a new "Status" field to "Post Settings" to match the web.
This feature was made possible thanks to the streamlined publishing introduced in 24.9, the new SwiftUI-based "Post Settings" that uses a plain struct to represent settings added in 26.0, and further improvements made to it in 26.4 with a new publishing flow based on "Post Settings".
Changes
0
and0
Technical Notes
The changes are mainly only in the UI. The only exception is that we also finally consolidated "publishing" and "saving" a post, so there is now a single method in
PostCoordinator
that syncs all the latest changes to the server (using the existing delta-update mechanism) and notifies the app.Screenshots
User Scenarios
1. Scheduling a password-protected post
schedule.mov
2. Returning a published post back in review
return-to-review.mov
Testing Instructions
I would suggest focusing on the following two scenarios:
It may be worth making sure that none of the bugs previously fixed in 24.9 are reintroduces. Release notes from 24.9: