Skip to content

Lazy render logs to increase performance #25046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twstokes merged 3 commits into from
Dec 5, 2025
+45 −25
Merged

Lazy render logs to increase performance #25046

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b15076
Lazy load log files to increase performance.
twstokes Dec 3, 2025
3a99db8
Refactor nested closures.
twstokes Dec 5, 2025
a5a8e3d
Lazy render logs in the new activity log view.
twstokes Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions WordPress/Classes/ViewRelated/Me/Help & Support/SupportActivityDetailsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@

var body: some View {
ScrollView {
Text(viewModel.logText)
.font(.subheadline)
.frame(maxWidth: .infinity, alignment: .leading)
.padding()
LazyVStack(alignment: .leading, spacing: 0) {
ForEach(Array(viewModel.logLines.enumerated()), id: \.offset) { _, line in

Check warning on line 16 in WordPress/Classes/ViewRelated/Me/Help & Support/SupportActivityDetailsView.swift

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this code to not nest more than 2 closure expressions. 


See more on https://sonarcloud.io/project/issues?id=wordpress-mobile_WordPress-iOS&issues=AZrmFNhfH-7Qd36mI8Ox&open=AZrmFNhfH-7Qd36mI8Ox&pullRequest=25046
Text(line)
.frame(maxWidth: .infinity, alignment: .leading)
}
}
.font(.subheadline)
.padding()
}
.navigationTitle(viewModel.logDate)
.navigationBarTitleDisplayMode(.inline)
Expand All @@ -32,7 +36,7 @@
}

private final class SupportActivityDetailsViewModel: ObservableObject {
let logText: String
let logLines: [String]
let logDate: String

init(logFile: DDLogFileInfo) {
Expand All @@ -45,15 +49,17 @@

guard let logData = try? Data(contentsOf: URL(fileURLWithPath: logFile.filePath)),
let logText = String(data: logData, encoding: .utf8) else {
self.logText = ""
self.logLines = []
return
}
self.logText = logText
self.logLines = logText
.split(separator: "\n", omittingEmptySubsequences: false)
.map(String.init)
}

func buttonShareTapped() {
let activityVC = UIActivityViewController(
activityItems: [logText],
activityItems: [logLines.joined(separator: "\n")],
applicationActivities: nil
)

Expand Down