-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Stats: Add an option to disable automatic comparisons #25143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
7cd32d0 to
db3ea40
Compare
| VStack(spacing: Constants.step1) { | ||
| chartHeaderView | ||
| .padding(.trailing, -Constants.step0_5) | ||
| if dateRange.comparison != .off || metrics.count == 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to show it for a (pretty rate) scenario where you add a chart and remove all metrics form it except for one.
e194d1e to
8079909
Compare
|
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30472 | |
| Version | PR #25143 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8079909 | |
| Installation URL | 50cp207j4po6o |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30472 | |
| Version | PR #25143 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8079909 | |
| Installation URL | 3el50obmv2la8 |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |





Fixes CMM-785: Add a way to turn comparisons with previous periods off.
Screenshots
With this change, users can make the new interface appear more like the simpler production implementation. When you disable comparisons, it still shows the basic trend indicators, which matches the web and the production version on mobile. In the future, we should probably add a dedicated screen for managing these preferences and add more options – can't satisfy everyone with just the defaults.
Before / After
I also slightly changed how the menu item looks: