Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 19, 2025

See internal discussion at pbArwn-7sp-p2

I opened a PR for this because #816 cannot be merged without first resolving conflicts. There is only one conflict, the deleted podspec.

While the podspec should stay deleted, this PR is useful to show the changes from #822. I think they are fine to merge and bring into WordPress-Jetpack-Reader, but I'll let @kean and @crazytonyli give they're more expert opinion on it.

After this land in #816, we can merge that into trunk.

@mokagio mokagio requested review from crazytonyli and kean June 19, 2025 04:49
@mokagio mokagio force-pushed the mokagio/prepare-wpios-edition-for-merge branch from 37148b6 to 62938ce Compare June 20, 2025 00:24
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please note I have an open PR targeting wpios-edition. It looks like I need to update some tests though. #839

@mokagio mokagio merged commit c3e8741 into wpios-edition Jun 22, 2025
5 of 7 checks passed
@mokagio mokagio deleted the mokagio/prepare-wpios-edition-for-merge branch June 22, 2025 23:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants