Add Mac support to Release Toolkit actions #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Many of the Release Toolkit actions only included iOS in the available platforms that could be used with that action. With Day One Mac, most of those actions can be used on Mac as well as iOS. This PR adds Mac as a supported platform for all the relevant actions so Day One Mac can use them as well. I went ahead and updated all the relevant actions even if Day One Mac isn't currently using them, just for the sake of not having to make a new Release Toolkit release in the future in case more of them end up being needed.
For the two actions I changed in the
commonfolder, I switched them from[:ios, :android].include?(platform)totrueto match the other actions incommon.For the actions in the
iosfolder, I changed them fromplatform == :iosto[:ios, :mac.include?(platform). A few of them had already been updated, I assume for Simplenote Mac.I know it may not make sense to have Mac support in Release Toolkit actions that are specifically labeled "iOS". Because Day One Mac and Simplenote Mac are the only Automattic apps that might even potentially use them right now, I think it makes sense to just add Mac support for these actions rather than duplicating them into a separate
macfolder. Especially because all of those actions would be just be exact copies of the code within the iOS actions.How to Test
to this:
bundle installto get the changes from this PR's branchbundle exec fastlane mac test_mac_supportChecklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.