Additional tests for ios_get_app_version
#451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid relying on implementation details
…d of manually parsing it
4 tasks
AliSoftware
reviewed
Feb 11, 2023
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Already reviewed as part of iangmaia#1
Please add a CHANGELOG entry (under the Internal Changes section) first though
Contributor
Author
Done. |
AliSoftware
approved these changes
Feb 11, 2023
This was referenced Apr 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR improves the existing method
Ios::VersionHelper::read_from_config_file(), making it more reliable and robust by using the gemxcodeproj, as well as adding better error handling. Some additional tests cases were also implemented.This need came up as I was testing the code and noticed that possible format variations for the
.xcconfigfile were not being treated properly and there was no error handling.Related PRs
ios_get_app_versioniangmaia/release-toolkit#1Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.