Skip to content

Remove unused dependencies bigdecimal and activesupport #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazytonyli merged 3 commits into from
Jul 4, 2023
Merged

Remove unused dependencies bigdecimal and activesupport #504

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3242e3
Remove unused dependencies bigdecimal and activesupport
crazytonyli Jun 12, 2023
0986b94
Add a changelog
crazytonyli Jul 3, 2023
161dec9
Add fastlane as a dependency
crazytonyli Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

- Adds `if_exists` parameter to `upload_to_s3` action, with possible values `:skip`, `:fail`, and `:replace`. [#495]
- The `create_release` action now prints and returns the URL of the created GitHub Release. [#503]
- Removes two dependencies bigdecimal and activesupport. [#504]

### Bug Fixes

Expand Down
3 changes: 0 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ PATH
remote: .
specs:
fastlane-plugin-wpmreleasetoolkit (8.1.0)
activesupport (>= 6.1.7.1)
bigdecimal (~> 1.4)
buildkit (~> 1.5)
chroma (= 0.2.0)
diffy (~> 3.3)
Expand Down Expand Up @@ -53,7 +51,6 @@ GEM
aws-sigv4 (1.5.2)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
bigdecimal (1.4.4)
buildkit (1.5.0)
sawyer (>= 0.6)
buildkite-test_collector (2.3.1)
Expand Down
8 changes: 0 additions & 8 deletions fastlane-plugin-wpmreleasetoolkit.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ Gem::Specification.new do |spec|
# since this would cause a circular dependency

# spec.add_dependency 'your-dependency', '~> 1.0.0'
spec.add_dependency 'activesupport', '>= 6.1.7.1'
spec.add_dependency 'buildkit', '~> 1.5'
spec.add_dependency 'chroma', '0.2.0'
spec.add_dependency 'diffy', '~> 3.3'
Expand All @@ -41,13 +40,6 @@ Gem::Specification.new do |spec|
# `google-cloud-storage` is required by fastlane, but we pin it in case it's not in the future
spec.add_dependency 'google-cloud-storage', '~> 1.31'

# Some of the upstream code uses `BigDecimal.new` which version 2.0 of the
# `bigdecimal` gem removed. Until we'll find the time to identify the
# dependencies and see if we can move them to something compatible with
# modern `bigdecimal`, let's constrain the gem to a version still supporting
# `.new` but which warns about it deprecation.
spec.add_dependency 'bigdecimal', '~> 1.4'

spec.add_development_dependency 'bundler', '~> 2.0'
spec.add_development_dependency 'cocoapods', '~> 1.10'
# Use at least Fastlane 2.210.0 to ensure compatibility with the Xcode 14 toolchain
Expand Down