Skip to content

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Aug 12, 2024

What does it do?

What it says on the tin.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@AliSoftware AliSoftware requested a review from a team August 12, 2024 10:21
@AliSoftware AliSoftware self-assigned this Aug 12, 2024
@AliSoftware AliSoftware added the dependencies Pull requests that update a dependency file label Aug 12, 2024
@AliSoftware AliSoftware enabled auto-merge August 12, 2024 10:22
@AliSoftware AliSoftware merged commit 2bfe5c3 into trunk Aug 12, 2024
@AliSoftware AliSoftware deleted the nokogiri-update branch August 12, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants