buildkite_pipeline_upload: make sure environment keys and values are Strings
#608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
reviewed
Oct 30, 2024
lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_pipeline_upload_action.rb
Outdated
Show resolved
Hide resolved
Comment on lines
10
to
11
| # Both keys and values need to be passed as strings | ||
| environment = params[:environment].to_h { |k, v| [k.to_s, v.to_s] } |
Co-authored-by: Olivier Halligon <[email protected]>
…ake the absolute vs. relative path handling
AliSoftware
approved these changes
Oct 30, 2024
mokagio
approved these changes
Oct 30, 2024
| FastlaneCore::ConfigItem.new( | ||
| key: :pipeline_file, | ||
| description: 'The path to the YAML pipeline file to upload', | ||
| description: 'The path to the YAML pipeline file to upload. If a relative path is provided, it will be prefixed with the `.buildkite/` folder path. Absolute paths are used as-is', |
Contributor
There was a problem hiding this comment.
Leaving the option to pass an absolute path is excellent
lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_pipeline_upload_action.rb
Outdated
Show resolved
Hide resolved
…_pipeline_upload_action.rb Co-authored-by: Gio Lodi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Follow-up to the discussions in https://github.com/woocommerce/woocommerce-android/pull/12839/files#r1821331463. This PR:
environmentparameter are strings.buildkiteto thepipeline_fileparameter , enforcing our conventionsChecklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.