Skip to content

Fix post-processing of PR URLs in create_github_release action #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 2 commits into from
Nov 13, 2024
Merged

Fix post-processing of PR URLs in create_github_release action #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ebf99
Fix post-processing of PR URLs in `create_github_release` action
AliSoftware Nov 12, 2024
ff0ad66
Add CHANGELOG entry
AliSoftware Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _None_

### Bug Fixes

_None_
- Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release` [#610]

### Internal Changes

Expand Down
6 changes: 4 additions & 2 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_github_release_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ def self.run(params)
version = params[:version]
assets = params[:release_assets]
release_notes = params[:release_notes_file_path].nil? ? '' : File.read(params[:release_notes_file_path])
# Replace full URLS to PRs/Issues with shorthand, because GitHub does not render them properly otherwise.
release_notes.gsub!(%r{https://github.com/([^/]*/[^/]*)/(pulls?|issues?)/([0-9]*)}, '\1#\3')
# Replace full URLs to PRs/Issues that are in `[https://some-url]` brackets with shorthand, because GitHub does not render them properly otherwise.
# That syntax is sometimes used by devs in `RELEASE-NOTES.txt` when pointing to a PR to another repo (e.g. Gutenberg PR from WP repo).
# We should NOT transform URLs to PRs/Issues that are in `[text](url)` form (those are valid), only the ones directly in `[]` brackets.
release_notes.gsub!(%r{\[https://github.com/([^/]*/[^/]*)/(pulls?|issues?)/([0-9]*)\]}, '[\1#\3]')
prerelease = params[:prerelease]
is_draft = params[:is_draft]

Expand Down