Skip to content

Fix file path issue in check_fonts_installed method #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 4 commits into from
Nov 21, 2024
Merged

Fix file path issue in check_fonts_installed method #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d82ddb7
Fix file path issue in check_fonts_installed method
irfano Nov 19, 2024
0217b3c
Add CHANGELOG entry
irfano Nov 19, 2024
c8d0b7d
Optimize reading stylesheet in check_fonts_installed
irfano Nov 20, 2024
71a2785
Merge branch 'trunk' into fix/check-fonts-installed-method-for-screen…
irfano Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ _None_

### Bug Fixes

- Fix `check_fonts_installed` step in `create_promo_screenshots` [#615]
- Fix broken `draw_text_to_canvas` method for `create_promo_screenshots` [#614]

### Internal Changes
Expand Down
3 changes: 2 additions & 1 deletion lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def check_fonts_installed!(config:)
# Parse the first font in each `font-family` attribute found in all found CSS files.
# Only the first in each `font-family` font list matters, as others are fallbacks we don't want to use anyway.
font_families = all_stylesheets.flat_map do |s|
File.readlines(s).flat_map do |line|
stylesheet_path = resolve_path(s)
File.readlines(stylesheet_path).flat_map do |line|
attr = line.match(/font-family: (.*);/)&.captures&.first
attr.split(',').first.strip.gsub(/'(.*)'/, '\1').gsub(/"(.*)"/, '\1') unless attr.nil?
end
Expand Down