You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Author: Be sure to create and publish a GitHub Release pointing to trunk once this PR gets merged,
copy/pasting the following text as the GitHub Release's description:
### Breaking Changes
- The `prototype_build_details_comment` action now relies on the `lane_context` of `firebase_app_distribution` instead of the one from `appcenter_upload` for the implicit metadata and download URL to use in the comment.
This is in the context of us moving from App Center (which will be shut down in March 2025) to Firebase App Distribution as our primary mechanism to distribute prototype builds. [#630]
### New Features
- The `ios_lint_localizations` action now accepts a `fail_on_strings_not_in_base_language` parameter (defaulting to `true`) to control whether to report violations when finding strings in translations that are not present in the base language. [#631]
### Internal Changes
- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered. [#626]
So we're going with a major version that includes my prototype_build_details_comment after all, even if that means we'll have to wait until the FAD migration is ready to be adopted for repos (especially WCiOS) to also be able to benefit from ios_lint_localizations flexibility to not-crash on unknown translations?
As opposed to reverting my prototype_build_details_comment PR, make a 12.5.0 minor version, then restoring my prototype_build_details_comment PR to be ready for next major?
I'm ok with this if that was the intent and we consider that this adoption of ios_lint_localizations can wait before being adopted in WCiOS; but I just wanted to check what the plan was (especially regarding pdnsEh-210-p2)
So we're going with a major version that includes my prototype_build_details_comment after all, even if that means we'll have to wait until the FAD migration is ready to be adopted for repos (especially WCiOS) to also be able to benefit from ios_lint_localizations flexibility to not-crash on unknown translations?
As opposed to reverting my prototype_build_details_comment PR, make a 12.5.0 minor version, then restoring my prototype_build_details_comment PR to be ready for next major?
I'm ok with this if that was the intent and we consider that this adoption of ios_lint_localizations can wait before being adopted in WCiOS; but I just wanted to check what the plan was (especially regarding pdnsEh-210-p2)
Tbh I keep going back and for with this 😓 -- part of me says to just move forward and have WCiOS ready for the FAD migration, which should be soon anyway, and avoid the revert and intermediate releases; part of me wants to be on the more conservative side, play safe and adopt ios_lint_localizations sooner -- just by writing this now I'm thinking of following that route instead, so we can close this issue sooner, which is independent of the FAD, leave the FAD matter to be handled separately.
Then next steps would be to 1) close this PR, 2) create a PR reverting #630 and 3) creating the 12.5.0 release PR.
just by writing this now I'm thinking of following that route instead, so we can close this issue sooner, which is independent of the FAD, leave the FAD matter to be handled separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing new version
13.0.0.What's Next
PR Author: Be sure to create and publish a GitHub Release pointing to
trunkonce this PR gets merged,copy/pasting the following text as the GitHub Release's description: