Skip to content

Extract release notes lines to an array to later join it #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iangmaia merged 2 commits into from
Apr 14, 2025
Merged

Extract release notes lines to an array to later join it #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea170fd
Extract release notes lines to an array to later join it
iangmaia Apr 14, 2025
64a3175
Update changelog
iangmaia Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _None_

### Bug Fixes

_None_
- Fix error in `extract_release_notes_for_version`, avoiding modifying a frozen string. [#644]

### Internal Changes

Expand Down
6 changes: 3 additions & 3 deletions ...tlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ def self.run(params)
release_notes_file_path = params[:release_notes_file_path]
extracted_notes_file_path = params[:extracted_notes_file_path]

extracted_notes = ''
extracted_lines = []
extract_notes(release_notes_file_path, version) do |line|
extracted_notes += line
extracted_lines << line
end
extracted_notes.chomp!('') # Remove any extra empty line(s) at the end
extracted_notes = extracted_lines.join.chomp('') # Combine lines and remove any extra empty line(s) at the end

unless extracted_notes_file_path.nil? || extracted_notes_file_path.empty?
File.write(extracted_notes_file_path, extracted_notes)
Expand Down