Skip to content

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Sep 18, 2025

Closes AINFRA-1149

What does it do?

  • Adds Microsoft Store as allowed platforms for the upload_build_to_apps_cdn action
  • Add comments pointing to the source of those allowed enum values in the backend code
  • Update Unit tests accordingly

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations.
  • Add Unit Tests (aka specs/*_spec.rb) if applicable.
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass.
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

And reformat constants for allowed values to use multiline syntax + comments pointing to backend source of enum values
Copy link

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding Microsoft Store support for Studio AppX builds 👍

Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AliSoftware AliSoftware merged commit 58d280f into trunk Sep 19, 2025
8 checks passed
@AliSoftware AliSoftware deleted the AINFRA-1149/apps-cdn-new-platform branch September 19, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants