-
Notifications
You must be signed in to change notification settings - Fork 1
Replace secret retrieval with az-artifact-authenticate step in CI workflow #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Gcaya 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…thenticate Co-authored-by: Gcaya <8711024+Gcaya@users.noreply.github.com>
…ld.ps1 Co-authored-by: Gcaya <8711024+Gcaya@users.noreply.github.com>
Co-authored-by: Gcaya <8711024+Gcaya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the CI pipeline's Azure DevOps artifact feed authentication by replacing manual secret retrieval with a dedicated reusable workflow action. The change simplifies the CI configuration while maintaining backward compatibility and improving cross-platform support.
- Replaces manual secret retrieval step with
az-artifact-authenticateaction - Updates build script to support
VSS_NUGET_ACCESSTOKENauthentication alongside existing methods - Removes redundant .NET setup step and simplifies environment variable configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Replaces secret retrieval and .NET setup with consolidated az-artifact-authenticate action |
Build.ps1 |
Adds support for VSS_NUGET_ACCESSTOKEN authentication with az-api-key |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR updates the CI pipeline to use the shared
az-artifact-authenticatestep fromworkleap/wl-reusable-workflowsfor Azure DevOps artifact feed authentication, replacing the previous manual secret retrieval approach.Changes Made
CI Workflow (
.github/workflows/ci.yml)Get gsoft-nuget-feed-ado-pat secretstep with theaz-artifact-authenticateactionactions/setup-dotnet@v4step (now included inaz-artifact-authenticate)NUGET_API_KEY(authentication now handled viaVSS_NUGET_ACCESSTOKEN)variables: ${{ toJSON(vars) }}for cleaner parameter passingBuild Script (
Build.ps1)VSS_NUGET_ACCESSTOKENauthentication alongside existingNUGET_API_KEY"az-api-key"as the API key when authenticating with Azure DevOps tokensAuthentication Flow
The new authentication logic follows this precedence:
NUGET_API_KEYon Linux (existing behavior)VSS_NUGET_ACCESSTOKENon any platform (new Azure Artifacts authentication)Benefits
The
az-artifact-authenticatestep handles Azure CLI login, .NET setup, and credential provider installation automatically, reducing the CI workflow complexity while providing more robust authentication.Fixes #120.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.