Skip to content

Conversation

@MatDumoulin
Copy link
Contributor

@MatDumoulin MatDumoulin commented Oct 20, 2025

Jira issue link: SGPD-4098

Description of changes

Warnings were raised when having multiple blank lines but the code formatter (in Rider and using the dotnet cli at least) is not fixing these issues automatically.

This PR is to lower the severity of this issue so that it doesn't block the CI for the different products.

  • Updated the documentation of the project to reflect the changes
  • Added new tests that cover the code changes

@MatDumoulin MatDumoulin requested a review from a team as a code owner October 20, 2025 16:43
Copilot AI review requested due to automatic review settings October 20, 2025 16:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lowers the severity of the IDE2000 rule (multiple consecutive blank lines) from warning to suggestion because automatic code formatters in Rider and dotnet CLI do not fix this issue, which was blocking CI pipelines.

Key changes:

  • Reduces IDE2000 severity to prevent CI failures for an issue that cannot be auto-fixed
  • Removes trailing blank line at end of file

meziantou
meziantou previously approved these changes Oct 20, 2025
@meziantou meziantou merged commit 94880a1 into main Oct 20, 2025
7 checks passed
@meziantou meziantou deleted the SGPD-4098_lower_severity_multipleblanklines branch October 20, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants