Skip to content

Conversation

@geraldbarre-workleap
Copy link
Contributor

@geraldbarre-workleap geraldbarre-workleap commented Nov 20, 2025

Jira issue link: feng-1466

Description of changes

Breaking changes

Additional checks

  • Updated the documentation of the project to reflect the changes
  • Added new tests that cover the code changes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies to future versions that do not yet exist and modernizes the package build process. The changes upgrade the .NET SDK to 10.0.100, target framework to net10.0, and bump multiple analyzer packages to version 10.x or 5.x. Additionally, it refactors the assembly loading logic in ConfigurationFilesGenerator to include dependency resolution, and migrates from nuget.exe to dotnet pack for package creation.

  • Upgrades .NET SDK and target frameworks to version 10 (not yet released)
  • Updates analyzer package dependencies to non-existent versions
  • Improves assembly loading with dependency resolution logic

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
global.json Updates SDK version to 10.0.100 (non-existent version)
tools/ConfigurationFilesGenerator/ConfigurationFilesGenerator.csproj Updates target framework to net10.0 and upgrades package dependencies to future versions
tools/ConfigurationFilesGenerator/Program.cs Refactors assembly loading to add dependency resolution and extracts package download logic
tests/Workleap.DotNet.CodingStandards.Tests/Workleap.DotNet.CodingStandards.Tests.csproj Updates target framework to net10.0
tests/Workleap.DotNet.CodingStandards.Tests/PackageFixture.cs Migrates from nuget.exe to dotnet pack for package creation
tests/Workleap.DotNet.CodingStandards.Tests/CodingStandardTests.cs Updates ZipFile.ExtractToDirectory to async variant
Workleap.DotNet.CodingStandards.nuspec Updates analyzer package dependencies to future versions
Workleap.DotNet.CodingStandards.csproj Adds new project file for packaging support
Build.ps1 Switches from nuget.exe to dotnet pack command
src/files/analyzers/*.editorconfig Adds new analyzer rules from updated packages (generated files)

@geraldbarre-workleap geraldbarre-workleap merged commit ea10b97 into main Nov 21, 2025
13 checks passed
@geraldbarre-workleap geraldbarre-workleap deleted the feature/feng-1466 branch November 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants