Skip to content

Created team schema #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Created team schema #975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10fe95b
Created team schema
Daniel-olaO Apr 27, 2023
fc340f2
Added return statement
Daniel-olaO Jun 6, 2023
102c42d
Address PR comments
Daniel-olaO Jun 6, 2023
96829b6
Removed imports
Daniel-olaO Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/team.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ module.exports = function (sequelize, DataTypes) {
name: DataTypes.STRING,
description: DataTypes.STRING,
timestamps: true,
})
});
return Team;
}
6 changes: 4 additions & 2 deletions models/teamMember.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ module.exports = function (sequelize, DataTypes) {
},
timestamps: true,
})
TeamMember.belongsTo(Team, { foreignKey: 'team_id' })
TeamMember.belongsTo(User, { foreignKey: 'user_id' })
TeamMember.belongsTo(Team, { foreignKey: 'team_id' });
Copy link
Contributor

@rogdevil rogdevil Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build is still failing because you are using TeamMember.belongsTo in a wrong way you need to do it like this,
TeamMember.associate = (models) => { TeamMember.belongsTo(models.Team, { foreignKey: 'team_id'}) }
something like this, in your current implementation it could be possible that Team that you are importing is a empty object ... also remove the imports at the top they are not needed anymore

Copy link
Contributor

@rogdevil rogdevil Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference you can have a look at this file
here

TeamMember.belongsTo(User, { foreignKey: 'user_id' });

return TeamMember;
}