fix: handle signOut() when no session exists #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, signOut() silently did nothing when called without an active session, leaving users stuck on the logout page. Now signOut() handles the no-session case explicitly: - No session + no returnTo: throws NoSessionError - No session + returnTo + navigate:true: redirects to returnTo - No session + returnTo + navigate:false: resolves silently When navigate:false, errors are returned as rejected Promises to match the Promise<void> return type signature. Closes #98
nholden
approved these changes
Jan 2, 2026
Merged
nmajor25
added a commit
to RoundingWell/care-ops-frontend
that referenced
this pull request
Jan 8, 2026
To include workos/authkit-js#104 Which fixes a bug in our app where logout url redirect wasnt working properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
signOut()now throwsNoSessionErrorwhen called without an active session and noreturnToURLreturnTois provided but no session exists, redirects directly to that URLNoSessionErrorto public exports for consumer error handlingWhy
Previously,
signOut()silently did nothing when no session existed, leaving users stuck on the logout page with no feedback. This created a confusing UX when users visited/logoutdirectly, cleared cookies, or had expired sessions.Notes
navigate: false, errors are returned as rejected Promises to match thePromise<void>return type