don't transition to error state for fetch/etc. errors #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatheson
commented
Dec 30, 2024
Merged
mthadley
approved these changes
Dec 31, 2024
cmatheson
force-pushed
the
better-fetch-error-handling
branch
from
fbadeb6 to
f579f50
Compare
The ERROR state is meant to indicate terminal errors (like the session being over). authkit-js will not attempt to retrieve new tokens after when in an ERROR state. Temporary errors (like `fetch` or tab-lock errors) should _not_ move to the error state. This allows future calls to `getAccessToken` to attempt to retrieve a new token.
cmatheson
force-pushed
the
better-fetch-error-handling
branch
from
f579f50 to
de96d45
Compare
mthadley
reviewed
Dec 31, 2024
Comment on lines
+502
to
+508
| const errorScope = nock("https://api.workos.com") | ||
| .post("/user_management/authenticate", { | ||
| client_id: "client_123abc", | ||
| grant_type: "refresh_token", | ||
| }) | ||
| .times(2) | ||
| .replyWithError(new TypeError("Network Error")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERROR state is meant to indicate terminal errors (like the session being over). authkit-js will not attempt to retrieve new tokens after when in an ERROR state.
Temporary errors (like
fetchor tab-lock errors) should not move to the error state. This allows future calls togetAccessTokento attempt to retrieve a new token.