Allow onSuccess callback to update session #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nholden
commented
Sep 24, 2025
nholden
force-pushed
the
allow-on-success-to-update-session
branch
from
75c3b47 to
c496bd9
Compare
nicknisi
approved these changes
Sep 24, 2025
Member
nicknisi
left a comment
nicknisi
left a comment
There was a problem hiding this comment.
Changes look good! When shipping this, would you consider this to be a minor bump or a patch? I'm leaning towards minor since it technically changes the order of operations + enables new functionality. Thanks for looking into this!
Member
Author
Minor bump makes sense for the reason you mentioned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, it's not possible to refresh a token and save it to the session in the
onSuccesscallback in your callback route. That's becausehandleAuthcallssaveSessionwith the original token after it calls youronSuccesscallback.This PR allows changes you save to the session in your
onSuccesscallback to persist after redirecting.