fix(tests): move window.location patching and restoration to beforeEach/afterEach #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundaray
changed the title
Move window.location mocking into a nested describe block containing only the two tests that verify reload behavior. This ensures: - Other tests run with real window.location - Mock setup/teardown in beforeEach/afterEach guarantees cleanup even when assertions fail
nicknisi
approved these changes
Jan 6, 2026
Member
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the patching and restoration of
window.locationfrom inside the individual tests to thebeforeEachandafterEachhooks in thedescribeblock.Previously, if a test assertion failed before the inline restoration code ran,
window.locationwould remain mocked, potentially polluting subsequent tests. With this change,afterEachguarantees restoration regardless of test outcome.