Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ jobs:
name: Prettier
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Checkout
uses: actions/checkout@v6
- name: Setup Node
- uses: actions/setup-node@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: invalid YAML syntax - missing uses on the same line as the step name

Suggested change
- name: Setup Node
- uses: actions/setup-node@v6
- name: Setup Node
uses: actions/setup-node@v6
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 20:21

Comment:
**syntax:** invalid YAML syntax - missing `uses` on the same line as the step name

```suggestion
      - name: Setup Node
        uses: actions/setup-node@v6
```

How can I resolve this? If you propose a fix, please make it concise.

with:
node-version: 20
node-version-file: .nvmrc
- name: Install Dependencies
run: npm install
- name: Prettier
Expand All @@ -28,10 +30,12 @@ jobs:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Checkout
uses: actions/checkout@v6
- name: Setup Node
- uses: actions/setup-node@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: invalid YAML syntax - missing uses on the same line as the step name

Suggested change
- name: Setup Node
- uses: actions/setup-node@v6
- name: Setup Node
uses: actions/setup-node@v6
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 35:36

Comment:
**syntax:** invalid YAML syntax - missing `uses` on the same line as the step name

```suggestion
      - name: Setup Node
        uses: actions/setup-node@v6
```

How can I resolve this? If you propose a fix, please make it concise.

with:
node-version: 20
node-version-file: .nvmrc
- name: Install Dependencies
run: npm install
- name: Lint
Expand All @@ -41,10 +45,12 @@ jobs:
name: Build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Checkout
uses: actions/checkout@v6
- name: Setup Node
uses: actions/setup-node@v6
with:
node-version: 20
node-version-file: .nvmrc
- name: Install Dependencies
run: npm install
- name: Build
Expand All @@ -55,10 +61,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [20, 22]
node: [20, 22, 24]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Checkout
uses: actions/checkout@v6
- name: Setup Node
- uses: actions/setup-node@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: invalid YAML syntax - missing uses on the same line as the step name

Suggested change
- name: Setup Node
- uses: actions/setup-node@v6
- name: Setup Node
uses: actions/setup-node@v6
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 68:69

Comment:
**syntax:** invalid YAML syntax - missing `uses` on the same line as the step name

```suggestion
      - name: Setup Node
        uses: actions/setup-node@v6
```

How can I resolve this? If you propose a fix, please make it concise.

with:
node-version: ${{ matrix.node }}
- name: Install Dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coana-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Run Coana CLI
id: coana-cli
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/coana-guardrail.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
separator: ' '

- name: Checkout the ${{github.base_ref}} branch
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
ref: ${{github.base_ref}} # checkout the base branch (usually master/main).

- name: Use Node.js 20.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: step name now references "Node.js 20.x" but actually uses version 24 from .nvmrc

Suggested change
- name: Use Node.js 20.x
- name: Use Node.js
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/coana-guardrail.yml
Line: 21:21

Comment:
**style:** step name now references "Node.js 20.x" but actually uses version 24 from `.nvmrc`

```suggestion
      - name: Use Node.js
```

How can I resolve this? If you propose a fix, please make it concise.

uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: 20.x
node-version-file: .nvmrc

- name: Run Coana on the ${{github.base_ref}} branch
run: |
Expand All @@ -37,7 +37,7 @@ jobs:
run: sudo chown -R $USER:$USER .

- name: Checkout the current branch
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
clean: true

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
name: Publish to NPM
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 18
node-version-file: .nvmrc
registry-url: 'https://registry.npmjs.org'

- name: Install Dependencies
Expand Down
1 change: 0 additions & 1 deletion .node-version

This file was deleted.

1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24
Loading