Merged
Conversation
2e57c56 to
88d3e71
Compare
Use a promise to ensure the value is set
f9f8255 to
0196de1
Compare
dandorman
reviewed
Feb 18, 2025
Co-authored-by: Dan Dorman <dan@workos.com>
dandorman
reviewed
Feb 19, 2025
997c947 to
82df4b5
Compare
dandorman
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Cookie Singleton with SessionStorageManager
Overview
This PR replaces our current cookie singleton approach with a more flexible and testable SessionStorageManager class. The key changes:
cookie.tsin favor of a newsessionStorage.tsmoduleSessionStorageManagerclass to handle session storage configurationKey Changes
configureSessionStorageandgetSessionStoragefunctionsSessionStorageManagerclass with proper promise-based configuration handlingAuthKitLoaderOptionsto support custom storage and cookie configurationsExample Usage
Fixes #2