Conversation
87e970f to
07056f4
Compare
dandorman
approved these changes
Mar 8, 2025
Contributor
dandorman
left a comment
There was a problem hiding this comment.
This seems good to me. (I had a few comments, but nothing that should block this, imo.)
I think it would be great if something like this existed in the Node WorkOS client itself, but ... the perfect is the enemy of the good, and this is an excellent starting place that will improve devex for our Remix users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, users must provide secrets and configuration values through environment variables (
process.env). This has several limitations:Solution
This PR adds a new
configure()function that enables programmatic configuration with multiple flexible patterns:Implementation Details
Benefits
Testing
Additional Changes
workosinstance (parity with authkit-nextjs)getWorkOS()function to user to get access to WorkOS instance (parity with authkit-nextjs)Breaking Changes
None. This is a non-breaking enhancement that maintains compatibility with existing code.
Fixes #38