Add userId and sessionId to TokenRefreshError#8
Merged
Conversation
Provides context for debugging when token refresh fails (e.g., rate limits).
Greptile OverviewGreptile SummaryThis PR enhances
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Client
participant AuthKitCore
participant WorkOS API
participant TokenRefreshError
Client->>AuthKitCore: validateAndRefresh(session)
AuthKitCore->>AuthKitCore: Extract sessionId from JWT claims
AuthKitCore->>AuthKitCore: refreshTokens(refreshToken, orgId, {userId, sessionId})
AuthKitCore->>WorkOS API: authenticateWithRefreshToken()
alt Refresh Succeeds
WorkOS API-->>AuthKitCore: New tokens + user
AuthKitCore-->>Client: Refreshed session
else Refresh Fails (e.g., rate limit)
WorkOS API-->>AuthKitCore: Error
AuthKitCore->>TokenRefreshError: new TokenRefreshError(msg, cause, {userId, sessionId})
TokenRefreshError-->>AuthKitCore: Error with context
AuthKitCore-->>Client: TokenRefreshError (includes userId, sessionId for debugging)
end
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userIdandsessionIdproperties toTokenRefreshErrorfor better debugging context when token refresh failsAuthKitError,SessionEncryptionError,TokenValidationError,TokenRefreshError) from packageWhen a token refresh fails (e.g., due to rate limiting), the error now includes the affected user and session:
This is backward compatible - no changes required by consuming packages.