Skip to content

[V8] remove direct process.env access, replacing with getEnv helper #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicknisi merged 2 commits into from
Jul 22, 2025
Merged

[V8] remove direct process.env access, replacing with getEnv helper #1312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0edbad6
remove direct process.env access, replacing with getEnv helper
nicknisi Jul 17, 2025
dd157ae
remove comment
nicknisi Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/workos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import { Actions } from './actions/actions';
import { Vault } from './vault/vault';
import { ConflictException } from './common/exceptions/conflict.exception';
import { CryptoProvider } from './common/crypto/crypto-provider';
import { getEnv } from './common/utils/env';

const VERSION = '8.0.0-beta.2';

Expand Down Expand Up @@ -71,11 +72,7 @@ export class WorkOS {
readonly options: WorkOSOptions = {},
) {
if (!key) {
// process might be undefined in some environments
this.key =
typeof process !== 'undefined'
? process?.env.WORKOS_API_KEY
: undefined;
this.key = getEnv('WORKOS_API_KEY');

if (!this.key) {
throw new NoApiKeyProvidedException();
Expand All @@ -87,8 +84,8 @@ export class WorkOS {
}

this.clientId = this.options.clientId;
if (!this.clientId && typeof process !== 'undefined') {
this.clientId = process?.env.WORKOS_CLIENT_ID;
if (!this.clientId) {
this.clientId = getEnv('WORKOS_CLIENT_ID');
}

const protocol: string = this.options.https ? 'https' : 'http';
Expand Down