Skip to content

Commit 11deee3

Browse files
author
Rohan Jadvani
authored
Remove directory_ prefix from Directory Sync arguments (#25)
1 parent 5c5dfe1 commit 11deee3

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

tests/test_directory_sync.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def test_get_user(self, mock_user, mock_request_method):
153153
mock_response.status_code = 200
154154
mock_response.response_dict = mock_user
155155
mock_request_method("get", mock_response, 200)
156-
response = self.directory_sync.get_user(directory_user="directory_usr_id")
156+
response = self.directory_sync.get_user(user="directory_usr_id")
157157
assert response.status_code == 200
158158
assert response.response_dict == mock_user
159159

@@ -162,7 +162,7 @@ def test_get_group(self, mock_group, mock_request_method):
162162
mock_response.status_code = 200
163163
mock_response.response_dict = mock_group
164164
mock_request_method("get", mock_response, 200)
165-
response = self.directory_sync.get_group(directory_group="directory_grp_id")
165+
response = self.directory_sync.get_group(group="directory_grp_id")
166166
assert response.status_code == 200
167167
assert response.response_dict == mock_group
168168

workos/directory_sync.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,34 +76,32 @@ def list_groups(
7676
token=workos.api_key,
7777
)
7878

79-
def get_user(self, directory_user):
79+
def get_user(self, user):
8080
"""Gets details for a single provisioned Directory User.
8181
8282
Args:
83-
directory_user (str): Directory User unique identifier.
83+
user (str): Directory User unique identifier.
8484
8585
Returns:
8686
dict: Directory User response from WorkOS.
8787
"""
8888
return self.request_helper.request(
89-
"directory_users/{directory_user}".format(directory_user=directory_user),
89+
"directory_users/{user}".format(user=user),
9090
method=REQUEST_METHOD_GET,
9191
token=workos.api_key,
9292
)
9393

94-
def get_group(self, directory_group):
94+
def get_group(self, group):
9595
"""Gets details for a single provisioned Directory Group.
9696
9797
Args:
98-
directory_group (str): Directory User unique identifier.
98+
group (str): Directory Group unique identifier.
9999
100100
Returns:
101101
dict: Directory Group response from WorkOS.
102102
"""
103103
return self.request_helper.request(
104-
"directory_groups/{directory_group}".format(
105-
directory_group=directory_group
106-
),
104+
"directory_groups/{group}".format(group=group),
107105
method=REQUEST_METHOD_GET,
108106
token=workos.api_key,
109107
)

0 commit comments

Comments
 (0)