Skip to content

Conversation

@mxlje
Copy link
Contributor

@mxlje mxlje commented Jun 15, 2025

Description

This PR adds the ability to update the external_id for a user. I was surprised this wasn’t in already but it seemed like a simple addition.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[X] Yes

Documentation should be updated still, I have not looked into that.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Adds support for external_id management in the WorkOS Ruby SDK, enabling users to update and retrieve external IDs for user records.

  • Added external_id field to lib/workos/user.rb for model attribute access and JSON serialization
  • Extended update_user method in lib/workos/user_management.rb to support external ID updates
  • Added comprehensive test coverage in spec/lib/workos/user_management_spec.rb for the new functionality
  • Documentation updates are still pending for API reference and code snippets

3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

@mxlje
Copy link
Contributor Author

mxlje commented Jun 29, 2025

@stacurry any way we can get this pushed along? Not sure who to ping. Cheers!

@ericroberts ericroberts merged commit 85d8249 into workos:main Jun 30, 2025
2 checks passed
@ericroberts
Copy link
Contributor

Thanks for the contribution @mxlje! I've merged them. Going to add external_id to a couple other missing places before issuing a new release but will get that done today.

@mintuhouse
Copy link

Can it be added to ::WorkOS::UserManagement.create_user too along with update_user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants