Remove SR support #671
Draft
Remove SR support #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is a problem with this PR where although the contracts work, the CLI tests are broken or the steps need to be changed. the new version would needs all the SR logic from the CLI removed, but it breaks a test where it goes back to an earlier release and tries to upgrade an ntt deployment. |
kcsongor
force-pushed
the
evm/executor
branch
from
97a6bea to
d1b8b46
Compare
kcsongor
reviewed
Sep 6, 2025
| const EXCLUDED_DIFF_PATHS = [ | ||
| "transceivers.wormhole.executor" | ||
| const EXCLUDED_DIFF_PATHS: string[] = [ | ||
| // REMOVED: "transceivers.wormhole.executor" |
There was a problem hiding this comment.
I think we should keep this, and just force it to be true for newer deployments. Then think about what to do for older deployments?
kcsongor
force-pushed
the
evm/executor
branch
from
d1b8b46 to
827150b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove standard and special relaying from EVM contracts in order to reduce costs when using the executor.