Skip to content

Conversation

evan-gray
Copy link
Contributor

This PR adds the integrator-relevant files for Custom Consistency Level and Executor.

@evan-gray evan-gray requested a review from nonergodic as a code owner August 13, 2025 13:55
@nonergodic
Copy link
Collaborator

I'd also get rid of the natspec and only highlight what's actually important, because this comment from the README

NatSpec is avoided because it favors a "box-checking" approach towards documentation rather than focusing on essentials and rationales

was taking aim at exactly this sort of documentation:

/// @notice Returns the configuration for a given emitter address.
/// @param emitterAddress The emitter address for which the config has been set.
/// @return The configuration.
function getConfiguration(address emitterAddress) external returns (bytes32);

@evan-gray evan-gray force-pushed the add-consistency-level-and-executor branch 2 times, most recently from 7e9b25e to 6ec17ec Compare August 30, 2025 17:10
@evan-gray evan-gray requested a review from nonergodic August 30, 2025 17:11
@evan-gray
Copy link
Contributor Author

@nonergodic thanks for the feedback, I tried to match the comments style more and just had the one issue with makeAdditionalBlocksConfig if you could take another look, thanks!

@evan-gray evan-gray force-pushed the add-consistency-level-and-executor branch from 6ec17ec to 377a7be Compare September 10, 2025 18:12
@evan-gray evan-gray force-pushed the add-consistency-level-and-executor branch from 377a7be to 3a61b04 Compare September 10, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants