ci: enable "Poorly Chosen Identifer" lint#4718
Open
johnsaigle wants to merge 2 commits intowormhole-foundation:mainfrom
Open
ci: enable "Poorly Chosen Identifer" lint#4718johnsaigle wants to merge 2 commits intowormhole-foundation:mainfrom
johnsaigle wants to merge 2 commits intowormhole-foundation:mainfrom
Conversation
johnsaigle
requested review from
djb15,
evan-gray,
fergarrui and
panoel
as code owners
johnsaigle
added
quality
johnsaigle
changed the title
johnsaigle
force-pushed
the
ci-static-check-ccq
branch
from
9bb5af2 to
d090bfa
Compare
djb15
reviewed
Mar 24, 2026
node/cmd/ccq/p2p.go
Outdated
| networkID string, | ||
| bootstrapPeers string, | ||
| ethRpcUrl string, | ||
| ethRPCURL string, |
Collaborator
There was a problem hiding this comment.
Imo this is harder to read now?
Contributor
Author
There was a problem hiding this comment.
Fair, I'll look into renaming this or adding an exception.
Contributor
Author
There was a problem hiding this comment.
renamed to rpcURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.