Tackling bullet points 3&4 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengtlofgren
changed the title
a5-pickle
force-pushed
the
shim/reorganize-ix-logic
branch
from
890fba8 to
6ff462f
Compare
bengtlofgren
force-pushed
the
shim/reorganize-ix-logic_init-fast-market-order-changes
branch
from
bcd0d84 to
3494ab2
Compare
a5-pickle
force-pushed
the
shim/reorganize-ix-logic
branch
from
6ff462f to
f2b2bea
Compare
bengtlofgren
force-pushed
the
shim/reorganize-ix-logic_init-fast-market-order-changes
branch
from
3494ab2 to
f4487ff
Compare
Base automatically changed from
shim/reorganize-ix-logic
to
create_and_close_fast_market_order
May 15, 2025 15:43
Base automatically changed from
create_and_close_fast_market_order
to
shim/integration
May 15, 2025 16:08
bengtlofgren
force-pushed
the
shim/reorganize-ix-logic_init-fast-market-order-changes
branch
from
f4487ff to
13923ad
Compare
a5-pickle
suggested changes
May 15, 2025
solana/programs/matching-engine/src/fallback/processor/initialize_fast_market_order.rs
Show resolved
Hide resolved
solana/programs/matching-engine/src/fallback/processor/initialize_fast_market_order.rs
Outdated
Show resolved
Hide resolved
solana/programs/matching-engine/src/fallback/processor/initialize_fast_market_order.rs
Outdated
Show resolved
Hide resolved
…ize_fast_market_order.rs Co-authored-by: A5 Pickle <[email protected]>
…ize_fast_market_order.rs Co-authored-by: A5 Pickle <[email protected]>
bengtlofgren
force-pushed
the
shim/reorganize-ix-logic_init-fast-market-order-changes
branch
from
eda43a1 to
a7248ac
Compare
a5-pickle
approved these changes
May 16, 2025
a5-pickle
deleted the
shim/reorganize-ix-logic_init-fast-market-order-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
from_routerendpoint as an account to the initialize fast market order.Changes
The main changes are to the instruction itself in
matching-engine/src/fallback/processor/initialize_fast_market_order.rsThe rest of the changes are to make the tests pass because a new account needs to be passed in, and a more verbose error is given.