solana: add shim integration instructions #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5-pickle
force-pushed
the
main
branch
2 times, most recently
from
1b4b80b to
c50bfdb
Compare
bengtlofgren
force-pushed
the
create_and_close_fast_market_order
branch
from
004946e to
230f2d5
Compare
bengtlofgren
force-pushed
the
create_and_close_fast_market_order
branch
8 times, most recently
from
331a3ac to
110de70
Compare
solana/modules/matching-engine-testing/tests/utils/constants.rs
Outdated
Show resolved
Hide resolved
a5-pickle
suggested changes
Apr 21, 2025
There was a problem hiding this comment.
I need to do another round after this because this PR is so huge.
Some other things to consider:
- Consider removing the
to_account_metasmethod and just create those account metas directly, unless there is a benefit to just creating the account metas separately from building the instruction. - Use American English (e.g. "intialize" instead of "initialise") to be consistent with the existing naming conventions of the matching engine.
solana/programs/matching-engine/src/fallback/processor/prepare_order_response.rs
Outdated
Show resolved
Hide resolved
solana/programs/matching-engine/src/fallback/processor/prepare_order_response.rs
Outdated
Show resolved
Hide resolved
solana/programs/matching-engine/src/fallback/processor/prepare_order_response.rs
Outdated
Show resolved
Hide resolved
bengtlofgren
force-pushed
the
create_and_close_fast_market_order
branch
from
3452de4 to
52def68
Compare
bengtlofgren
force-pushed
the
create_and_close_fast_market_order
branch
from
7b566c5 to
52def68
Compare
* solana: fix idl build workflows: remove rustup default * solana: update Makefile --------- Co-authored-by: A5 Pickle <[email protected]>
Started off integration test work
clean up initialize fast market order
clean up instruction serde
update helpers and fix existing instructions
Co-authored-by: Bengt Lofgren <[email protected]>
a5-pickle
changed the title
a5-pickle
dismissed
their stale review
Paired with @bengtlofgren to address requested changes
a5-pickle
approved these changes
May 15, 2025
a5-pickle
force-pushed
the
create_and_close_fast_market_order
branch
from
36e7882 to
2af2c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background reading
To get a better understanding of the testing engine, please read the docstring in
tests/testing_engine/engine.rs. The readme file undertests/README.mdis reproduced below.How to read the tests
Each test is found in the
integration_tests.rsfile.Each test is a function that is annotated with
#[tokio::test].Each test is a test for a specific scenario, and uses the
TestingEngineto execute a series of instruction triggers.The
TestingEngineis initialised with aTestingContext. TheTestingContextholds the solana program test context, the actors, the transfer direction, created vaas, as well as some constants.The
TestingEngineis used to execute the instruction triggers in the order they are provided. See thetesting_engine/engine.rsfile for more details.Integration Tests
Initialize program
What is expected:
Create CCTP router endpoints
What is expected:
Create fast market order
What is expected:
Close fast market order
What is expected: