evm: TransceiverRegistry split #22
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
evm/mm
branch
2 times, most recently
from
a40b01a to
ada34c1
Compare
bruce-riley
force-pushed
the
evm_TransceiverRegistry_split
branch
2 times, most recently
from
33be533 to
59cceb0
Compare
bruce-riley
force-pushed
the
evm_TransceiverRegistry_split
branch
3 times, most recently
from
f7485db to
d1ac2a8
Compare
bruce-riley
force-pushed
the
evm_TransceiverRegistry_split
branch
from
d1ac2a8 to
8925b73
Compare
bruce-riley
force-pushed
the
evm/mm
branch
2 times, most recently
from
d0179b9 to
7eb1451
Compare
bruce-riley
force-pushed
the
evm_TransceiverRegistry_split
branch
from
8925b73 to
8b8adc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
TransceiverRegisteryand moves the admin functionality into a helper contract. The goal is to reduce code space in theNttManagercontract.This split was accomplished by creating a
TransceiverRegistryBasecontract inherited by the existingTransceiverRegisteryand a newTransceiverRegistryAdminwhich holds all of the admin code. The admin functions inTransceiverRegisterythen usedelegatecallto invoke the functions onTransceiverRegistryAdmin.