Open
Conversation
Major refactoring to externalize hardcoded SKU data and support Belgian/Swiss multi-language stores: SKU Data Externalization: - Remove 300+ lines of hardcoded SKU functions from SKUData.swift - Create iPadModels-intl.json with all iPad SKU data - Create AccessoryModels-intl.json with Studio Display, AirPods Pro, Apple Pencil data - Update MacModels-intl.json with missing Mac models from hardcoded functions - Refactor SKUDataLoader.swift to load dynamically from JSON files Multi-Language Store Support: - Add Belgian stores: be-nl (Dutch), be-fr (French) - Add Swiss stores: ch-de (German), ch-fr (French) - Update all JSON files with multi-language region data - Add Country structs in Countries.swift for language variants Benefits: - Maintainable, data-driven SKU management - Easy to add/update products without code changes - Proper support for multi-language European stores - Clean architecture with consistent JSON structure - Backward compatibility maintained
- Update Xcode project configuration - Fix duplicate notification prevention with 24-hour cooldown - Improve notification system with better messaging - Update analytics and model types - Enhance UI components and view models
Owner
|
@drallgood thanks for the PR! cool to see some action in this repo 😊 i gave a quick once-over to the code-as is, and it all looked workable to me (granted, I haven't looked at this codebase in some time). let me know when you're finished with your changes, and I'll do a final check before approving. cheers! |
Author
|
@worthbak Yeah.. still working on it ;) I will let you know ehn I'm done |
…e-prefix size consistency, and distribution logs; update per-model JSON catalogs incl. CarrierOffers; Xcode and app config updates
…ity; add distribution logs; no iPhone impact
…eep other HTTP errors as errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.