Skip to content

feat: add ArchiveCommandHandler.Handle() tests & harden ArchiveCommandHandler #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woutervanranst merged 46 commits into from
Nov 12, 2025

chore: cleanup usings

a8cf53a
Select commit
Loading
Failed to load commit list.
Merged

feat: add ArchiveCommandHandler.Handle() tests & harden ArchiveCommandHandler #82

chore: cleanup usings
a8cf53a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 12, 2025 in 2s

22 new alerts

New alerts in code changed by this pull request

  • 13 warnings
  • 9 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 202 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
emptyFile
Loading
is useless, since its value is never read.

Check warning on line 309 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
storageBuilder
Loading
is useless, since its value is never read.

Check warning on line 349 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
command
Loading
is useless, since its value is never read.

Check warning on line 170 in src/Arius.Core.Tests/Features/Commands/Archive/MockArchiveStorageBuilder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'MemoryStream' is created but not disposed.

Check warning on line 157 in src/Arius.Core.Tests/Features/Commands/Archive/MockArchiveStorageBuilder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'MemoryStream' is created but not disposed.

Check warning on line 152 in src/Arius.Core.Tests/Features/Commands/Archive/MockArchiveStorageBuilder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'MemoryStream' is created but not disposed.

Check warning on line 966 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
failingFile
Loading
is useless, since its value is never read.

Check warning on line 893 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
baselineFile
Loading
is useless, since its value is never read.

Check warning on line 649 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
initialFileCount
Loading
is useless, since its value is never read.

Check warning on line 700 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
existingFile
Loading
is useless, since its value is never read.

Check warning on line 763 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
expectedFileCount
Loading
is useless, since its value is never read.
This assignment to
existingPointerCount
Loading
is useless, since its value is never read.

Check warning on line 810 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
expectedFileCount
Loading
is useless, since its value is never read.
This assignment to
existingPointerCount
Loading
is useless, since its value is never read.

Check warning on line 856 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning test

This assignment to
expectedFileCount
Loading
is useless, since its value is never read.
This assignment to
existingPointerCount
Loading
is useless, since its value is never read.

Check notice on line 39 in src/Arius.Core.Tests/Utils.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note test

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check notice on line 1081 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 448 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 447 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 446 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 445 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 384 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 381 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.

Check notice on line 33 in src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to System.IO.Path.Combine Note test

Call to 'System.IO.Path.Combine'.