Fix failing alternate cron test

[swissspidy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a failing alternate cron test by enhancing the test environment setup. It configures a local WordPress server and modifies the cron request mechanism to correctly route and validate cron spawns within the testing context. This ensures the test accurately reflects successful cron functionality under the alternate cron constant, resolving the previous 403 Forbidden error.

Highlights

• Test Environment Setup: Introduced a local wp server setup within the test scenario, complete with a php.ini file for error logging.
• Cron Request Modification: Added a mu-plugin to dynamically modify the cron_request URL, replacing https://example.com with http://localhost:8080 and disabling SSL verification, to ensure proper communication with the local test server.
• Test Assertion Update: Updated the wp cron test assertion to expect a 'Success' message in STDOUT, indicating that the cron spawning is now working as expected, while still verifying the ALTERNATE_WP_CRON warning in STDERR.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a failing test for ALTERNATE_WP_CRON. The fix involves setting up a local web server during the test and adding a must-use plugin to rewrite the cron request URL to target this local server. This ensures the cron spawn request succeeds, allowing the test to pass as expected. The changes are logical and effectively address the issue. I've added one suggestion to make the URL rewriting in the test more robust by using home_url() instead of a hardcoded string.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!