Skip to content

Fix failing tests when object cache is on #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Mar 25, 2026
Merged

Fix failing tests when object cache is on #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/comment-recount.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: Recount comments on a post
3
"""

When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->posts, array( "comment_count" => 1 ), array( "ID" => 1 ) );'`
When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->posts, array( "comment_count" => 1 ), array( "ID" => 1 ) ); clean_post_cache( 1 );'`
And I run `wp post get 1 --field=comment_count`
Then STDOUT should be:
"""
Expand Down
1 change: 1 addition & 0 deletions features/menu-item.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ Feature: Manage WordPress menu items
| Child | {CHILD_ID} | {PARENT_ID} |

When I run `wp menu item delete {PARENT_ID}`
And I run `wp cache flush`
And I run `wp menu item list grandparent-test --fields=title,db_id,menu_item_parent`
Then STDOUT should be a table containing rows:
| title | db_id | menu_item_parent |
Expand Down
1 change: 1 addition & 0 deletions features/option-list.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Feature: List WordPress options

@skip-object-cache
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added @skip-object-cache tag doesn’t appear to be handled anywhere in this repository (no runner config/docs reference it), so it may have no effect unless the external test harness explicitly filters on it. To make this scenario reliably pass with object cache enabled, consider setting the transient rows directly in the options table (e.g. add _transient_* / _transient_timeout_* options) instead of relying on wp transient set, which bypasses DB storage when an external object cache is active.

Copilot uses AI. Check for mistakes.
Scenario: Using the `--transients` flag
Given a WP install
And I run `wp transient set wp_transient_flag wp_transient_flag`
Expand Down
2 changes: 1 addition & 1 deletion features/term-recount.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: Recount terms on a taxonomy
"""
1
"""
When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->term_taxonomy, array( "count" => 3 ), array( "term_id" => {TERM_ID} ) );'`
When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->term_taxonomy, array( "count" => 3 ), array( "term_id" => {TERM_ID} ) ); clean_term_cache( {TERM_ID}, "category" );'`
And I run `wp term get category {TERM_ID} --field=count`
Then STDOUT should be:
"""
Expand Down
Loading