Skip to content

Fix docstring indent issue in feature files #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Apr 11, 2025
Merged

Fix docstring indent issue in feature files #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 47 additions & 47 deletions features/media-fix-orientation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,67 +34,67 @@ Feature: Fix WordPress attachments orientation

When I run `wp media fix-orientation --dry-run`
Then STDOUT should contain:
"""
3 "Portrait Four" (ID {PORTRAIT_FOUR}) will be affected.
"""
"""
3 "Portrait Four" (ID {PORTRAIT_FOUR}) will be affected.
"""

And STDOUT should contain:
"""
3 "Landscape Five" (ID {LANDSCAPE_FIVE}) will be affected.
"""
"""
3 "Landscape Five" (ID {LANDSCAPE_FIVE}) will be affected.
"""

And STDOUT should contain:
"""
3 "Landscape Two" (ID {LANDSCAPE_TWO}) will be affected.
"""
"""
3 "Landscape Two" (ID {LANDSCAPE_TWO}) will be affected.
"""

And STDOUT should contain:
"""
Success: 3 of 3 images will be affected.
"""
"""
Success: 3 of 3 images will be affected.
"""

When I run `wp media fix-orientation`
Then STDOUT should contain:
"""
3 Fixing orientation for "Portrait Four" (ID {PORTRAIT_FOUR}).
"""
"""
3 Fixing orientation for "Portrait Four" (ID {PORTRAIT_FOUR}).
"""

And STDOUT should contain:
"""
3 Fixing orientation for "Landscape Five" (ID {LANDSCAPE_FIVE}).
"""
"""
3 Fixing orientation for "Landscape Five" (ID {LANDSCAPE_FIVE}).
"""

And STDOUT should contain:
"""
3 Fixing orientation for "Landscape Two" (ID {LANDSCAPE_TWO}).
"""
"""
3 Fixing orientation for "Landscape Two" (ID {LANDSCAPE_TWO}).
"""

And STDOUT should contain:
"""
Success: Fixed 3 of 3 images.
"""
"""
Success: Fixed 3 of 3 images.
"""

# Verify orientation fix.
When I run `wp media fix-orientation`
Then STDOUT should contain:
"""
3 No orientation fix required for "Portrait Four" (ID {PORTRAIT_FOUR}).
"""
"""
3 No orientation fix required for "Portrait Four" (ID {PORTRAIT_FOUR}).
"""

And STDOUT should contain:
"""
3 No orientation fix required for "Landscape Five" (ID {LANDSCAPE_FIVE}).
"""
"""
3 No orientation fix required for "Landscape Five" (ID {LANDSCAPE_FIVE}).
"""

And STDOUT should contain:
"""
3 No orientation fix required for "Landscape Two" (ID {LANDSCAPE_TWO}).
"""
"""
3 No orientation fix required for "Landscape Two" (ID {LANDSCAPE_TWO}).
"""

And STDOUT should contain:
"""
Success: Images already fixed.
"""
"""
Success: Images already fixed.
"""

# On newer versions (5.3+) the image is already considered fixed.
# On WP 4.9 tests this results in "Couldn't fix orientation".
Expand All @@ -109,23 +109,23 @@ Feature: Fix WordPress attachments orientation

When I run `wp media fix-orientation {PORTRAIT_SIX}`
Then STDOUT should be:
"""
1/1 Fixing orientation for "Portrait Six" (ID {PORTRAIT_SIX}).
Success: Fixed 1 of 1 images.
"""
"""
1/1 Fixing orientation for "Portrait Six" (ID {PORTRAIT_SIX}).
Success: Fixed 1 of 1 images.
"""

# Verify orientation fix.
When I run `wp media fix-orientation {PORTRAIT_SIX}`
Then STDOUT should be:
"""
1/1 No orientation fix required for "Portrait Six" (ID {PORTRAIT_SIX}).
Success: Image already fixed.
"""
"""
1/1 No orientation fix required for "Portrait Six" (ID {PORTRAIT_SIX}).
Success: Image already fixed.
"""

@require-wp-4.0
Scenario: Fix orientation for non existent image
When I try `wp media fix-orientation 9999`
Then STDERR should be:
"""
Error: No images found.
"""
"""
Error: No images found.
"""