Skip to content

Removed unused $new_assoc_args variable in wp rewrite structure subcommand #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 3 commits into from
May 23, 2025
Merged

Removed unused $new_assoc_args variable in wp rewrite structure subcommand #73

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5cfaef
Remove unused variable from the file.
viralsampat-multidots May 22, 2025
22a008a
Remove extra comments and white space
viralsampat-multidots May 22, 2025
e9dfa89
Remove extra white space
viralsampat-multidots May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Rewrite_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,13 @@

// Launch a new process to flush rewrites because core expects flush
// to happen after rewrites are set
$new_assoc_args = [];

Check failure on line 163 in src/Rewrite_Command.php

View workflow job for this annotation

GitHub Actions / code-quality / PHPCS 

Whitespace found at end of line
$cmd = 'rewrite flush';

Check warning on line 164 in src/Rewrite_Command.php

View workflow job for this annotation

GitHub Actions / code-quality / PHPCS 

Equals sign not aligned correctly; expected 1 space but found 12 spaces
if ( Utils\get_flag_value( $assoc_args, 'hard' ) ) {
$cmd .= ' --hard';

Check warning on line 166 in src/Rewrite_Command.php

View workflow job for this annotation

GitHub Actions / code-quality / PHPCS 

Equals sign not aligned correctly; expected 1 space but found 19 spaces
$new_assoc_args['hard'] = true;

Check failure on line 167 in src/Rewrite_Command.php

View workflow job for this annotation

GitHub Actions / code-quality / PHPCS 

Whitespace found at end of line
// Check if the 'mod_rewrite' Apache module is enabled.

Check failure on line 168 in src/Rewrite_Command.php

View workflow job for this annotation

GitHub Actions / code-quality / PHPCS 

Whitespace found at end of line
// If not, display a warning since regenerating the .htaccess file requires this module.
if ( ! in_array( 'mod_rewrite', (array) WP_CLI::get_config( 'apache_modules' ), true ) ) {
WP_CLI::warning( 'Regenerating a .htaccess file requires special configuration. See usage docs.' );
}
Expand Down
Loading