PHPStan level 9

Author: swissspidy

phpstan.neon.dist

@@ -9,6 +9,7 @@ parameters:
     - vendor/php-stubs/wordpress-stubs/wordpress-stubs.php
   treatPhpDocTypesAsCertain: false
   ignoreErrors:
+    - identifier: class.notFound
     - identifier: missingType.property
     - identifier: missingType.parameter
     - identifier: missingType.return

src/Shell_Command.php

@@ -27,18 +27,15 @@ class Shell_Command extends WP_CLI_Command {
 	 *     => string(6) "WP-CLI"
 	 */
 	public function __invoke( $_, $assoc_args ) {
-		/**
-		 * @var array<class-string> $implementations
-		 */
+		$class = WP_CLI\Shell\REPL::class;
+
 		$implementations = array(
-			'Psy\\Shell',
-			'Boris\\Boris',
-			'WP_CLI\\Shell\\REPL',
+			\Psy\Shell::class,
+			\Boris\Boris::class,
+			WP_CLI\Shell\REPL::class,
 		);
 
-		if ( Utils\get_flag_value( $assoc_args, 'basic' ) ) {
-			$class = 'WP_CLI\\Shell\\REPL';
-		} else {
+		if ( ! Utils\get_flag_value( $assoc_args, 'basic' ) ) {
 			foreach ( $implementations as $candidate ) {
 				if ( class_exists( $candidate ) ) {
 					$class = $candidate;
@@ -51,10 +48,13 @@ public function __invoke( $_, $assoc_args ) {
 		 * @var class-string $class
 		 */
 
-		if ( 'Psy\\Shell' === $class ) {
+		if ( \Psy\Shell::class === $class ) {
 			$shell = new Psy\Shell();
 			$shell->run();
 		} else {
+			/**
+			 * @var class-string<WP_CLI\Shell\REPL> $class
+			 */
 			$repl = new $class( 'wp> ' );
 			$repl->start();
 		}

src/WP_CLI/Shell/REPL.php

@@ -83,6 +83,7 @@ private function prompt() {
 
 		$done = false;
 		do {
+			// @phpstan-ignore booleanNot.alwaysTrue
 			$prompt = ( ! $done && false !== $full_line ) ? '--> ' : $this->prompt;
 
 			$fp = popen( self::create_prompt_cmd( $prompt, $this->history_file ), 'r' );