Skip to content

Improve MariaDB detection #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 17 commits into from
Mar 28, 2025
Merged

Improve MariaDB detection #246

swissspidy merged 17 commits into from
Mar 28, 2025

Conversation

@swissspidy
Copy link
Member

@swissspidy swissspidy commented Mar 27, 2025 •
edited
Loading

To-do: correctly set WP_CLI_TEST_DBTYPE=mariadb in https://github.com/wp-cli/.github

@codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/FeatureContext.php 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mrsdizzie
Copy link
Member

mrsdizzie commented Mar 28, 2025

All tests passing now. This requires the latest version of wp-cli/wp-cli#6072

I temporarily updated composer.json here but that probably needs to be undone before merging.

I added $this->variables['MYSQL_BINARY'] = $mysql_binary; to be used in behat tests (examples in the linked pr).

@swissspidy swissspidy marked this pull request as ready for review March 28, 2025 08:02
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2025 08:02
@swissspidy swissspidy added this to the 4.3.13 milestone Mar 28, 2025
@swissspidy swissspidy merged commit c388578 into main Mar 28, 2025
51 checks passed
@swissspidy swissspidy deleted the fix/mariadb-support branch March 28, 2025 12:22
@swissspidy swissspidy mentioned this pull request May 5, 2025
Merged
@schlessera schlessera mentioned this pull request May 5, 2025
Closed
Copilot AI mentioned this pull request Nov 1, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees

No one assigned

Labels

scope:testing

Projects

None yet

Milestone

4.3.13

Development

Successfully merging this pull request may close these issues.

3 participants

@swissspidy @mrsdizzie