Improve compatibility with other operating systems

.github/workflows/testing.yml

@@ -13,3 +13,34 @@ on:
 jobs:
   test:
     uses: wp-cli/.github/.github/workflows/reusable-testing.yml@main
+    with:
+      matrix: |
+        {
+          "include": [
+            {
+              "php": "8.4",
+              "wp": "latest",
+              "mysql": "mysql-8.0",
+              "os": "macos-15"
+            },
+            {
+              "php": "8.4",
+              "wp": "latest",
+              "dbtype": "sqlite",
+              "os": "macos-15"
+            },
+            {
+              "php": "8.4",
+              "wp": "latest",
+              "mysql": "mysql-8.0",
+              "os": "windows-2025"
+            },
+            {
+              "php": "8.4",
+              "wp": "latest",
+              "dbtype": "sqlite",
+              "os": "windows-2025"
+            }
+          ],
+          "exclude": []
+        }

bin/install-package-tests

@@ -15,9 +15,9 @@ is_numeric() {
         *) return 0;;            # returns 0 if numeric
     esac
 }
-# Promt color vars.
-C_RED="\033[31m"
-C_BLUE="\033[34m"
+# Prompt color vars.
+C_RED="\033[0;31m"
+C_BLUE="\033[0;34m"
 NO_FORMAT="\033[0m"
 
 HOST=localhost

composer.json

@@ -25,7 +25,7 @@
         "wp-cli/config-command": "^1 || ^2",
         "wp-cli/core-command": "^1 || ^2",
         "wp-cli/eval-command": "^1 || ^2",
-        "wp-cli/wp-cli": "^2.12",
+        "wp-cli/wp-cli": "^2.13",
         "wp-coding-standards/wpcs": "dev-develop",
         "yoast/phpunit-polyfills": "^1.0 || ^2.0 || ^3.0 || ^4.0"
     },

features/behat-steps.feature

@@ -28,7 +28,8 @@ Feature: Test that WP-CLI Behat steps work as expected
     Then the test-dir directory should not exist
 
   Scenario: Test "Given an empty cache" step
-    Given an empty cache
+    Given a WP installation
+    And an empty cache
     Then the {SUITE_CACHE_DIR} directory should exist
 
   Scenario: Test "Given a file" step
@@ -44,7 +45,8 @@ Feature: Test that WP-CLI Behat steps work as expected
       """
 
   Scenario: Test "Given a cache file" step
-    Given an empty cache
+    Given a WP installation
+    And an empty cache
     And a test-cache.txt cache file:
       """
       Cached content
@@ -410,27 +412,31 @@ Feature: Test that WP-CLI Behat steps work as expected
 
   @require-download
   Scenario: Test download step
-    Given an empty cache
+    Given a WP installation
+    And an empty cache
     And download:
       | path                       | url                                    |
       | {SUITE_CACHE_DIR}/test.txt | https://www.iana.org/robots.txt        |
     Then the {SUITE_CACHE_DIR}/test.txt file should exist
 
-  @require-wp @require-composer
+  # Skipped on Windows because of curl getaddrinfo() errors.
+  @require-wp @require-composer @skip-windows
   Scenario: Test WP installation with Composer
     Given a WP installation with Composer
     Then the composer.json file should exist
     And the vendor directory should exist
     When I run `wp core version`
     Then STDOUT should not be empty
 
-  @require-wp @require-composer
+  # Skipped on Windows because of curl getaddrinfo() errors.
+  @require-wp @require-composer @skip-windows
   Scenario: Test WP installation with Composer and custom vendor directory
     Given a WP installation with Composer and a custom vendor directory 'custom-vendor'
     Then the composer.json file should exist
     And the custom-vendor directory should exist
 
-  @require-wp @require-composer
+  # Skipped on Windows because of curl getaddrinfo() errors.
+  @require-wp @require-composer @skip-windows
   Scenario: Test dependency on current wp-cli
     Given a WP installation with Composer
     And a dependency on current wp-cli
@@ -439,8 +445,7 @@ Feature: Test that WP-CLI Behat steps work as expected
       wp-cli/wp-cli
       """
 
-
-
+  @require-linux
   Scenario: Test STDOUT should be empty
     When I run `echo -n ""`
     Then STDOUT should be empty
@@ -689,3 +694,4 @@ Feature: Test that WP-CLI Behat steps work as expected
     Then STDOUT should be CSV containing:
       | user_login | user_email        |
       | admin      | [email protected] |
+      | user2      | [email protected] |

features/steps.feature

@@ -61,7 +61,7 @@ Feature: Make sure "Given", "When", "Then" steps work as expected
   Scenario: Special variables
 
     When I run `echo {INVOKE_WP_CLI_WITH_PHP_ARGS-} cli info`
-    Then STDOUT should match /wp cli info/
+    Then STDOUT should match /(wp|wp\.bat) cli info/
     And STDERR should be empty
 
     When I run `echo {WP_VERSION-latest}`

features/testing.feature

@@ -11,6 +11,10 @@ Feature: Test that WP-CLI loads.
 
   Scenario: WP Cron is disabled by default
     Given a WP install
+    And the wp-config.php file should contain:
+      """
+      if ( defined( 'DISABLE_WP_CRON' ) === false ) { define( 'DISABLE_WP_CRON', true ); }
+      """
     And a test_cron.php file:
       """
       <?php
@@ -53,7 +57,8 @@ Feature: Test that WP-CLI loads.
       sqlite
       """
 
-  @require-sqlite
+  # Skipped on Windows because of curl getaddrinfo() errors.
+  @require-sqlite @skip-windows
   Scenario: Composer installation
     Given a WP install with Composer
 

phpstan.neon.dist

@@ -19,8 +19,6 @@ parameters:
     - WP_DEBUG_LOG
     - WP_DEBUG_DISPLAY
   ignoreErrors:
-    # Needs fixing in WP-CLI.
-    - message: '#Parameter \#1 \$cmd of function WP_CLI\\Utils\\esc_cmd expects array<string>#'
     - message: '#Dynamic call to static method#'
       path: 'tests/tests'
   strictRules:

phpunit.xml.dist

@@ -11,7 +11,6 @@
 	>
 	<testsuites>
 		<testsuite name="default">
-			<directory prefix="Spec" suffix=".php">tests/</directory>
 			<directory prefix="Test" suffix=".php">tests/tests</directory>
 		</testsuite>
 	</testsuites>