Allow max-age=0 value #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kpoelhekke wants to merge 1 commit into wp-graphql:main from kpoelhekke:main

kpoelhekke commented Dec 17, 2025

Problem

Setting max_age_header to 0 didn’t take effect.
Reasons:
1. WordPress treats taxonomy term name 0 as empty → value wasn’t saved.
2. Header logic used truthy checks, so 0 was ignored when computing/setting headers (including batch min selection).

Fix

Store zero using a sentinel term name zero so it persists; map back to integer 0 on read.

File

wp/plugins/wpgraphql-smart-cache/src/Document/MaxAge.php


          Allow max-age=0 value

ec16416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet