fix: date picker field returns incorrect data #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephfusco
previously approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug with the
date_pickerfield returning null when used as a nested field and different return_format options are set for the date format.Does this close any currently open issues?
closes: #212
Any other comments?
With the following ACF Field Group: acf-export-2024-06-17.json
And data added to a post using the field group:
Before
Fields of the date_picker and date_time_picker field type were returning the unix epoch (
00:00:00 UTC on 1 January 1970) - when nested on flexible content layoutsAfter
Now fields of the date_picker and date_time_picker field type return the expected values.